INTLY-2346 openshift 4 support #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@philbrookes Would you mind having a quick review of this? I will also add OpenShift 4 verification steps in the morning.
I still need to confirm OpenShift 3 backwards compatibility is working as expected.
OpenShift 4 Verification
oc status, note theapi.<my-cluster>URLtutorial-web-appDeploymentConfig:docker.io/aidenkeatingrht/tutorial-web-app:INTLY-2346OPENSHIFT_APIwith the value of theapi.<my-cluster>from earlierOPENSHIFT_VERSIONwith the value'4'OpenShift 3 Verification
v0.0.9USER_SSO_URLenv set to the user sso routedocker.io/aidenkeatingrht/tutorial-web-app:INTLY-2346