Skip to content

Conversation

@aidenkeating
Copy link
Contributor

@aidenkeating aidenkeating commented Aug 1, 2019

verification:

  • an integreatly cluster on openshift 3 is required
  • ensure the user-rhsso clusterserviceclass exists by searching for
    it on the main page (service catalog)
  • ensure USER_SSO_URL is set on the managed service broker env
    var
  • run this branch locally against the cluster
  • ensure that the user sso is now also provisioned at startup
  • ensure the link on the right-hand side works as expected

@tiffanynolan
Copy link
Collaborator

@aidenkeating Do you have a cluster running with this already that you could share? I'd like to verify the display of this in SolX.

@aidenkeating
Copy link
Contributor Author

@tiffanynolan I will set up an environment now for verification

@aidenkeating
Copy link
Contributor Author

@tiffanynolan @leaannegaffney This is provisioned on my cluster here https://tutorial-web-app-webapp.apps.akeating-242a.openshiftworkshop.com/, the admin user has been set up already

gaStatus: 'GA'
},
rhsso: {
prettyName: 'Red Hat Single Sign-On (Cluster)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finp I like how you referred to the 2 instances in the docs as those terms sound more user friendly. Ultimately, I'd like to only show the end-user SSO in the applications list and move the cluster level one to more of an admin screen/settings page. We're not there yet though so we do need some way to easily tell them apart for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiffanynolan @finp Just to confirm, should I be changing the naming of this in the web app (and if so, what to)? Or will it be changed in the documentation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aidenkeating my reading of @tiffanynolan comment is to go with what we have. I could add a note to docs if required.

@wtrocki wtrocki mentioned this pull request Aug 2, 2019
@pb82
Copy link
Contributor

pb82 commented Aug 2, 2019

@aidenkeating can you also add the user sso to the mock data here: https://github.com/integr8ly/tutorial-web-app/blob/master/server.js#L495

otherwise running the webapp locally won't work

@aidenkeating aidenkeating force-pushed the INTLY-2663-user-sso branch 2 times, most recently from 4188aa5 to 62b5ce4 Compare August 6, 2019 08:04
@aidenkeating
Copy link
Contributor Author

@leaannegaffney Mind taking a look?

Aiden Keating added 2 commits August 6, 2019 09:45
verification:
- an integreatly cluster on openshift 3 is required
- ensure the user-rhsso clusterserviceclass exists by searching for
  it on the main page (service catalog)
- ensure USER_SSO_URL is set on the managed service broker env
  var
- run this branch locally against the cluster
- ensure that the user sso is now also provisioned at startup
- ensure the link on the right-hand side works as expected
Copy link

@leaannegaffney leaannegaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on my cluster 👍

@aidenkeating aidenkeating merged commit a49120f into integr8ly:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants