-
Notifications
You must be signed in to change notification settings - Fork 53
INTLY-2663 add user sso provision to startup loading task #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTLY-2663 add user sso provision to startup loading task #493
Conversation
fee2985 to
76e91df
Compare
|
@aidenkeating Do you have a cluster running with this already that you could share? I'd like to verify the display of this in SolX. |
|
@tiffanynolan I will set up an environment now for verification |
|
@tiffanynolan @leaannegaffney This is provisioned on my cluster here https://tutorial-web-app-webapp.apps.akeating-242a.openshiftworkshop.com/, the |
| gaStatus: 'GA' | ||
| }, | ||
| rhsso: { | ||
| prettyName: 'Red Hat Single Sign-On (Cluster)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiffanynolan this doesn't align with doc at https://integr8ly.github.io/user-documentation/index.html?e=docs/getting-started.adoc#gs-adding-users-proc
but we can adjust as required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finp I like how you referred to the 2 instances in the docs as those terms sound more user friendly. Ultimately, I'd like to only show the end-user SSO in the applications list and move the cluster level one to more of an admin screen/settings page. We're not there yet though so we do need some way to easily tell them apart for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiffanynolan @finp Just to confirm, should I be changing the naming of this in the web app (and if so, what to)? Or will it be changed in the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aidenkeating my reading of @tiffanynolan comment is to go with what we have. I could add a note to docs if required.
|
@aidenkeating can you also add the user sso to the mock data here: https://github.com/integr8ly/tutorial-web-app/blob/master/server.js#L495 otherwise running the webapp locally won't work |
4188aa5 to
62b5ce4
Compare
|
@leaannegaffney Mind taking a look? |
verification: - an integreatly cluster on openshift 3 is required - ensure the user-rhsso clusterserviceclass exists by searching for it on the main page (service catalog) - ensure USER_SSO_URL is set on the managed service broker env var - run this branch locally against the cluster - ensure that the user sso is now also provisioned at startup - ensure the link on the right-hand side works as expected
62b5ce4 to
7ecb10f
Compare
leaannegaffney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on my cluster 👍
verification:
it on the main page (service catalog)
var