Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Apple notarization flow #902

Merged
merged 16 commits into from
Jan 17, 2025
Merged

Chore: Apple notarization flow #902

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
eaf20ec
kk update electron-builder for notarization errors
kkerti Jan 12, 2025
d41f368
kk specify creds in build script
kkerti Jan 12, 2025
870e682
kk attempt at notarization fix
kkerti Jan 12, 2025
230c3ee
kk change builder version
kkerti Jan 12, 2025
aa1a2fb
kk teamId is needed for this builder version
kkerti Jan 12, 2025
66a513e
kk revert debug command on nightly build
kkerti Jan 12, 2025
e7f0157
kk fix format
kkerti Jan 12, 2025
f0cc3c3
kk github runner was changed on macos
kkerti Jan 12, 2025
f58dc48
kk add retry script
kkerti Jan 12, 2025
0b0b72f
kk fix to only run on mac os build
kkerti Jan 12, 2025
6eb2093
kk step level if
kkerti Jan 12, 2025
fae910c
kk now the retry script fails. giving up for now.
kkerti Jan 12, 2025
1b8a8db
kk attempt #2
kkerti Jan 12, 2025
4db3da9
Try different versions of macos
danim1130 Jan 17, 2025
6fc1adf
Change setuptools install
danim1130 Jan 17, 2025
c39fce1
Add back runner os
danim1130 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kk attempt #2
  • Loading branch information
@kkerti
kkerti committed Jan 12, 2025
commit 1b8a8db629d3e7417434de674a6eba283b7c2481
9 changes: 7 additions & 2 deletions .github/workflows/build-matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ jobs:
if: ${{ inputs.versionOverride != '' }}
run: npm version ${{ inputs.versionOverride }} --no-git-tag-version

- name: Build
run: npm run ${{ inputs.exportScript }}
- name: Build with auto retry on fail (macos sporadically fails)
uses: nick-fields/retry@v3.0.0
env:
# gh repo token
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -62,6 +62,11 @@ jobs:

# Branch name
VITE_BRANCH_NAME: ${{ github.ref_name }}
with:
retry_on: error
timeout_minutes: 15
max_attempts: 3
command: npm run ${{ inputs.exportScript }}

- name: Upload artifacts
uses: actions/upload-artifact@v4
Expand Down
Loading