Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes, and features #842

Merged
merged 7 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed tests, removed unused files
  • Loading branch information
elsoazemelet committed Oct 21, 2024
commit 957942705f18ef8df5eeff34e418ef1477464163
13 changes: 7 additions & 6 deletions playwright-tests/pages/configPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ export class ConfigPage {
// Common Locators
this.addActionBlockButton = page.getByText("Add action block...");
this.selectAllCheckbox = page.locator(".w-fit > .border-white");
this.noActionAddActionButton = page.getByRole("button", {
name: "There are no actions",
});
this.noActionAddActionButton = page
.locator("div", { hasText: "There are no actions" })
.locator("button", { name: "Add" });

this.firstActionBlock = page.locator("#cfg-0");

Expand Down Expand Up @@ -106,9 +106,10 @@ export class ConfigPage {
}

async openActionsInIf() {
await this.page
.getByRole("button", { name: "Actions here are triggered" })
.click();
const divWithText = this.page.locator("div", {
hasText: "Actions here are triggered",
});
await divWithText.locator("button", { name: "Add" }).click();
}

async openActionsInElseIf() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
<span class="text-start">{text}</span>
<div class="flex flex-row gap-2">
<button
type="button"
class="flex rounded px-3 py-1 bg-commit items-center"
class:opacity-50={pasteDisabled}
on:click={() => handlePaste(index)}
Expand All @@ -59,6 +60,7 @@
<span class="text-white"> Paste </span>
</button>
<button
type="button"
class="rounded px-2 py-1 border border-pick group-hover:bg-pick/40"
on:click={handleShowActionPicker}
on:mouseenter={() => (isButtonHovered = true)}
Expand Down

This file was deleted.

Loading