Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social login support for web #831

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

danim1130
Copy link
Contributor

No description provided.

@danim1130 danim1130 linked an issue Oct 2, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Visit the preview URL for this PR (updated for commit 2afdc6d):

https://grid-editor-web--pr831-danim1130-web-social-4049sw60.web.app

(expires Wed, 09 Oct 2024 16:27:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@Greg-Orca
Copy link
Contributor

Greg-Orca commented Oct 4, 2024

It would be nice if the login worked by pressing 'Enter'. Related: intechstudio/profile-cloud#92

It would be more aesthetic to have a spinning indicator while the system fetches data.
https://github.com/user-attachments/assets/5b608c71-96a2-4761-b632-4ad409ed560d

@Greg-Orca
Copy link
Contributor

User enumeration risk in our password reset flow, as the system provides explicit feedback indicating whether an email is not registered.
Screenshot 2024-10-04 at 13 32 49

@Greg-Orca
Copy link
Contributor

Greg-Orca commented Oct 4, 2024

After logging in, reloading the page incorrectly displays the user as not logged in, though they remain authenticated in the background. This bug occurs because, upon refresh, the Cloud settings jump back from Nightly to Prod, causing login and logout functions to fail.

Screen.Recording.2024-10-04.at.14.02.39.mov

@Greg-Orca
Copy link
Contributor

Greg-Orca commented Oct 4, 2024

The "Can't register" message is no longer valid on Nightly, as Google Sign-In also functions as a registration method when using a new email address. Additionally, if a password reset is requested for an email used only for Google Sign-In, the user can set a new password and log in without using Google Sign-In.

Screenshot 2024-10-04 at 14 14 53

@danim1130 danim1130 merged commit 45c7f03 into stable Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Cloud Register and Social Login does not work on web
2 participants