Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XX16 and VSNX combined module implementation #816

Merged
merged 16 commits into from
Sep 5, 2024
Merged

XX16 and VSNX combined module implementation #816

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ac45eb0
SUKU protocol updated for proper hwcfg support
SukuWc Sep 2, 2024
91da3e2
SUKU unused grab action removed, cfg-# id handling implemented better…
SukuWc Sep 2, 2024
20ba8ec
SUKU 4 letter module type limitatiopn fixed
SukuWc Sep 2, 2024
f98bd2e
SUKU protocol updated to reflect vsn naming
SukuWc Sep 2, 2024
723b5b0
SUKU BU16 PO16 and EN16 combined into XX16.svelte
SukuWc Sep 3, 2024
0cbc0d0
SUKU VSNX implementation done
SukuWc Sep 3, 2024
982ecff
SUKU TEK2 renamed to VSN0 in test cases
SukuWc Sep 4, 2024
9380792
VSN modules added to tests
Greg-Orca Sep 4, 2024
febd52c
TEK2 back in the list
Greg-Orca Sep 4, 2024
d3f1608
no vsn0
Greg-Orca Sep 4, 2024
c5a1a7e
SUKU broken tests temporarly disabled
SukuWc Sep 5, 2024
4186aaf
SUKU tek2 removed from autotests
SukuWc Sep 5, 2024
c7e4d07
SUKU sync
SukuWc Sep 5, 2024
78eefb0
SUKU sync
SukuWc Sep 5, 2024
50efc69
SUKU feture flag added for unreleased modules, unreleased modules rem…
SukuWc Sep 5, 2024
0c097d6
SUKU fix button test
SukuWc Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SUKU tek2 removed from autotests
  • Loading branch information
@SukuWc
SukuWc committed Sep 5, 2024
commit 4186aafdfed7d620435edda3071816e4ddb4bd78
2 changes: 1 addition & 1 deletion playwright-tests/pages/connectModulePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class ConnectModulePage {
EN16: page.getByTestId("EN16"),
PBF4: page.getByTestId("PBF4"),
PO16: page.getByTestId("PO16"),
TEK2: page.getByTestId("TEK2"),
TEK0: page.getByTestId("TEK0"),
VSN1: page.getByTestId("VSN1"),
VSN1R: page.getByTestId("VSN1R"),
VSN2: page.getByTestId("VSN2"),
Expand Down
2 changes: 1 addition & 1 deletion playwright-tests/pages/modulePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class ModulePage {
EN16: page.getByTestId("EN16_dx:0;dy:0"),
PBF4: page.getByTestId("PBF4_dx:0;dy:0"),
PO16: page.getByTestId("PO16_dx:0;dy:0"),
TEK2: page.getByTestId("TEK2_dx:0;dy:0"),
VSN0: page.getByTestId("VSN0_dx:0;dy:0"),
VSN1: page.getByTestId("VSN1_dx:0;dy:0"),
VSN2: page.getByTestId("VSN2_dx:0;dy:0"),
VSN1R: page.getByTestId("VSN1R_dx:0;dy:0"),
Expand Down
8 changes: 4 additions & 4 deletions playwright-tests/tests/virtualModule.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ test.describe("Modules", () => {
"EN16",
"PBF4",
"PO16",
"TEK2",
"VSN0",
"VSN1",
"VSN2",
"VSN1R",
"VSN2",
];
for (const moduleName of moduleNames) {
test(`should add a ${moduleName}`, async () => {
Expand All @@ -42,8 +42,8 @@ test.describe("Module Operations", () => {
test("should change module", async () => {
await connectModulePage.addModule("BU16");
await modulePage.changeModule();
await connectModulePage.addModule("TEK2");
await expect(modulePage.modules["TEK2"]).toBeVisible();
await connectModulePage.addModule("PO16");
await expect(modulePage.modules["PO16"]).toBeVisible();
});

test("should remove module", async () => {
Expand Down
1 change: 0 additions & 1 deletion src/renderer/main/modals/AddVirtualModule.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
{ id: ModuleType.PBF4, type: ModuleType.PBF4, component: PBF4 },
{ id: ModuleType.PO16, type: ModuleType.PO16, component: XX16 },
{ id: ModuleType.TEK2, type: ModuleType.TEK2, component: VSNX },

{ id: ModuleType.VSN0, type: ModuleType.VSN0, component: VSNX },
{ id: ModuleType.VSN1, type: ModuleType.VSN1, component: VSNX },
{ id: ModuleType.VSN1R, type: ModuleType.VSN1R, component: VSNX },
Expand Down
Loading