Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩 PR: Added block name feature #783

Merged
merged 7 commits into from
Aug 7, 2024
Merged

🚩 PR: Added block name feature #783

merged 7 commits into from
Aug 7, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Jul 21, 2024

Closes #774

  • Action blocks can be named when clicked on the edit button on the block header
  • CodeBlock action block can be renamed when opened in monaco editor

Copy link
Contributor

github-actions bot commented Jul 21, 2024

Visit the preview URL for this PR (updated for commit 5eccd9c):

https://grid-editor-web--pr783-feat-blockname-n90ywlpd.web.app

(expires Mon, 12 Aug 2024 10:56:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@SukuWc
Copy link
Member

SukuWc commented Jul 22, 2024

Issues found:

  • Default config is missing all of the Local variable blocks!
  • If user chooses same name as the Default was then it should not be added to Lua to save character count
  • Default Code Block name is show in modal after close and re-open
  • Adding space to codeblock name (eg: "Test Script") causes is to not be rendered in action list after navigating to different event. It gets parsed into previous action block's last field (see screenshot)
    image

@SukuWc SukuWc marked this pull request as draft July 22, 2024 07:23
@SukuWc
Copy link
Member

SukuWc commented Jul 23, 2024

  • Clicking Pencil after edit should save
  • Hide pencil under dev flag in preferences

@elsoazemelet elsoazemelet marked this pull request as ready for review July 24, 2024 17:49
@SukuWc SukuWc merged commit ecc5576 into stable Aug 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional name field for actionblocks
2 participants