Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩 PR: Added remote firmware check #768

Merged
merged 10 commits into from
Jul 24, 2024
Merged

🚩 PR: Added remote firmware check #768

merged 10 commits into from
Jul 24, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Jul 5, 2024

Closes #766

Now required firmwares can be binded to editor versions in firmware.json.
If internet connection is not available, or the there is no matching entry in firmware.json, the default values are used in configuration.json

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Visit the preview URL for this PR (updated for commit b7be0fb):

https://grid-editor-web--pr768-feat-fw-9g58apql.web.app

(expires Tue, 30 Jul 2024 16:45:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet
Copy link
Contributor Author

Reset hardcoded editor requirements
CMS > editor requirements

@SukuWc
Copy link
Member

SukuWc commented Jul 23, 2024

Firmware download method still only downloads latest firmware. Please refactor firmware.ts:

  • firmwareDownload and firmwareNightlyDownload should not exist separately
  • firmwareDownload should have following args: targetFolder, product, arch, url
    • targetFolder is fetched from appSettings
    • product and arch are detected when detection the bootloader connection
    • url is calculated based on editor version, product, arch and required firmware from appSettings or CMS

@SukuWc SukuWc merged commit a782dd1 into stable Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firmware update should not update to latest, but to exact version that comes from CMS.
2 participants