Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚩 PR: Added partial preset load and element override #765

Merged
merged 7 commits into from
Jul 8, 2024
Merged

🚩 PR: Added partial preset load and element override #765

merged 7 commits into from
Jul 8, 2024

Conversation

elsoazemelet
Copy link
Contributor

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a000238):

https://grid-editor-web--pr765-feat-partialpreset-3j5pfmwu.web.app

(expires Mon, 15 Jul 2024 14:09:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Jul 5, 2024 •
edited
Loading

  • No blinking of Configmanager when loading preset
  • No compatibility when preset is broader than the target, only when it is narrower
  • Move element compatibility functions to grid-protocol

@elsoazemelet elsoazemelet merged commit 182163c into stable Jul 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load button preset to encoder, overlay shows encoders and buttons in different color
1 participant
@elsoazemelet