Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Web build now can use WebSerial API to use physical grid modules #726

Merged
merged 5 commits into from
May 24, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented May 17, 2024

Closes #719

  • Everything should work as previoulsy in the desktop build of Grid Editor
  • Added feature of requesting USB usage in web build of Grid Editor
  • When USB port access is enabled, physical grid modules can be used as in desktop builds

Copy link
Contributor

github-actions bot commented May 17, 2024

Visit the preview URL for this PR (updated for commit 96c64ee):

https://grid-editor-web--pr726-feat-webserial-vpcyrg17.web.app

(expires Fri, 31 May 2024 11:06:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet elsoazemelet changed the title Feat/web serial 🚩PR: Web build now can use WebSerial API to use physical grid modules May 21, 2024
@elsoazemelet
Copy link
Contributor Author

image

@kkerti
Copy link
Collaborator

kkerti commented May 21, 2024

Seems to work under chrome, but further testing required. I was able to quickly store a config change on my single connected module. After disconnecting the module and reconnecting, the "module connect" has to be re-enabled. Not sure if feature or bug.

Opinion:
The "Connect your modules!" should be opening up only on Chrome only. I think supporting other browsers is a fight not worth to pick. I think the writing on the modal should be something like:
You can use the browser Editor to configure your modules under Chrome only. Download Chrome *here*. If you are looking forward to explore Editor in virtual mode, start by adding virtual modules.
The modal should check the running browser type.

Better ux writing should be checked with @narayb.

It is a feature. Currently there is no way to solve the issue of reconnecting after the port was lost automatically.
The fix of runtime error during physical module connection enabling under browser differing from Chromre was implemented. The proper wording is to be selected, I will contact QA!

@SukuWc SukuWc merged commit d6267d0 into stable May 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement grid connection in browser build using the WebSerial API
3 participants