Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Fixed bug of runtime error when connecting/reconnecting many modules #714

Merged
merged 1 commit into from
May 7, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented May 5, 2024

Closes #690

Repro steps:

  • Connect 8+ modules
  • Connect and reconnect the modules, by rearranging the modules
  • After a while the error message should be thrown as a Warning in newer, and as a runtime error in older versions.

This error should not persist after this fix

Copy link
Contributor

github-actions bot commented May 5, 2024

Visit the preview URL for this PR (updated for commit d619f3b):

https://grid-editor-web--pr714-bug-alive-o47sm5u5.web.app

(expires Sun, 12 May 2024 11:45:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@SukuWc SukuWc merged commit e219b29 into stable May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property of undefined (alive)
2 participants