Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Added UI for Virtual Module management #678

Merged
merged 7 commits into from
May 6, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Apr 10, 2024

Closes #681

  • Changed Text of Virtual Module adder button on module connect dialog
  • Changed title of Add Virtual Module modal dialog
  • Added feature of virtual module add/remove/change on the grid UI (after adding at least one virtual module)
  • The selected virtual module can be removed
  • The selected virtual module can be changed
  • Other virtual modules can be added from any empty side of a virtual module
  • When connecting a physical module, all virtual modules should disappear
  • When connecting a physical module, the margin of the modules should be correct (no space should be visible where the module add button is visible on the bottom => between the modules and the page changer buttons)

@elsoazemelet elsoazemelet changed the title Added UI for Virtual Module management 🚩PR: Added UI for Virtual Module management Apr 10, 2024
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Visit the preview URL for this PR (updated for commit 6d0066e):

https://grid-editor-web--pr678-feat-multiplevirtual-ehgfaait.web.app

(expires Mon, 29 Apr 2024 15:30:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Apr 16, 2024

  • Make add button less prominent
  • Remove manual module add from dev settings

@narayb
Copy link
Collaborator

narayb commented Apr 18, 2024

In the dialog box, the 'add' button still says 'Get started!'.
kép

Proflle load doesn't select virtual module for removal.
virtual_selection

It's possible to create impossible layouts by removing modules in the middle.
kép

@elsoazemelet
Copy link
Contributor Author

In the dialog box, the 'add' button still says 'Get started!'. kép

Proflle load doesn't select virtual module for removal. virtual_selection virtual_selection

It's possible to create impossible layouts by removing modules in the middle. kép

Fixed in the latest commit! Please check new design proposel for the add module button!

@SukuWc
Copy link
Member

SukuWc commented Apr 22, 2024

Make hover hit-box larger
image

@SukuWc
Copy link
Member

SukuWc commented Apr 22, 2024

Also virutal module writeBuffer elements are never cleared, they just keep accumulating, please check using debug tools:
image

@elsoazemelet
Copy link
Contributor Author

All above is fixed in the latest commit

@elsoazemelet elsoazemelet merged commit 8492ef5 into stable May 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual module add/remove UX from middle pane
3 participants