Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Added setting of Disable Animations #625

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Feb 29, 2024

Closes #375

All EDITOR transitions and animations can be disabled from Preferences. This also automatically work without explicitly setting the animations to disabled, if in the OSs settings has the option for preferred reduced motion.

This should automatically work for ALL animations in EDITOR

Examples for the disabled animations:

  • Switching up ActionBlocks
  • Connecting Modules
  • Logger message display (no fade in)

@narayb
Copy link
Collaborator

narayb commented Mar 4, 2024

Firmware update animation is also enabled, makes it so that no red border appears at all.

Please make it so that a fallback static red border appears when animations are disabled in this case.

@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Mar 12, 2024

  • Add 3-way radio button for changing animation (on, off, auto). Display prefer reduced motion value.
  • Add red border to FW update modules when animations are disabled

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Visit the preview URL for this PR (updated for commit 87428d2):

https://grid-editor-web--pr625-feat-disabledanimati-u2v95k6e.web.app

(expires Mon, 25 Mar 2024 08:35:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet elsoazemelet merged commit ca33223 into stable Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User request: Disable all animations from perferences
2 participants