Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Added feature of GridLayout repositioning #624

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Feb 29, 2024

Closes #445

  • Now when holding down the control key and click + dragging with the mouse, the displayed modules can be repositioned
  • This repositioning is resets when clicking the Reset Grid Layout button on the Tracker
  • Check the tooltip for this feature next to the reset button
  • When the sticky container (that contains the page changer buttons) is would be outside of the middle panel, then it automatically sticks to the bottom of the screen
  • When no module is connected the positioning is reseted to the center
  • This feature is not persistent, the restart of the editor should reset the positioning.

@elsoazemelet elsoazemelet changed the title 🚩PR: Added feature of repositioning grid layout 🚩PR: Added feature of GridLayout repositioning Feb 29, 2024
@narayb
Copy link
Collaborator

narayb commented Mar 4, 2024

Reset Grid Layout is not a very descriptive name for the button that resets the position of the whole layout. Preferably is should somehow tell the user about that.

This button received the same highlight colors that all other buttons use now, like the Discard button. I still feel like that their highlighting is way too unnoticeable. Dark button in front of a dark background becoming slightly less dark is not a great way to highlight.

For some reason the tooltip disappears after clicking on the tooltip questionmark. This issue affects all tooltips, made a separate issue about this here: #629.

All other features work as described.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 9c519ab):

https://grid-editor-web--pr624-feat-controlsurface-4xph9mks.web.app

(expires Tue, 19 Mar 2024 12:32:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet elsoazemelet merged commit 8a75c14 into stable Mar 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow moving the control surface in the layout to different positions
2 participants