Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Added analytics, and unified profile/preset load overlay handling #596

Merged
merged 13 commits into from
Feb 14, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Feb 11, 2024

Analytics: Closes #370 and #564
Overlay: Closes #544

Disclaimer: Accidental pussh of the solution for #544 for feat/Analytics causes this branch to have solution for two category of issues.

Added analytics for:

  • Action block configuration change
  • Package download, uninstall, status change

Unified overlay display handling in code, differing displayed overlay by $selectedConfigrutaion type.

@elsoazemelet elsoazemelet changed the title 🚩PR: Added analytics for Action Block change and Package operations 🚩PR: Added analytics, and unified profile/preset load overlay handling Feb 11, 2024
@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Feb 12, 2024

TODO:

  • Make consistent analytics naming
  • Make runtime control element field less redundant, the element type number instead of string, add helper function to convert number to string to send to analytics
  • Make displayedOverlay into a separate store similiar to modal

@elsoazemelet elsoazemelet merged commit 8f0f10f into stable Feb 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant