🚩PR: Fixed runtime error for dropdown select list #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsoazemelet
changed the title
elsoazemelet
changed the title
|
Seemingly works as intended. |
elsoazemelet
commented
Jan 30, 2024
| type SelectOption = { title: string; value: any }; | ||
|
|
||
| function getDefaultSelected() { | ||
| const obj = options.find((e: SelectOption) => e.value === target); |
There was a problem hiding this comment.
Make it possible to accept invalid or undefined default target => Empty selectbox
elsoazemelet
commented
Jan 30, 2024
| } | ||
| function handleSelectionChange(selected: { label: string; value: any }) { | ||
| if (selected === target) { | ||
| return; |
There was a problem hiding this comment.
Use case:
NEVER update target if no actual selection change happened
If target is updated from the outside (correctly) change selection, (target should not change twice, in this case again from the inside)
If target is changed from the inside, propagate change to the outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #560
The fixed issue was the instable state management of MeltSelect.svelte. Fixed the selection state management logic.
Testing
The stresstesting of the select list is probably the way to go.
This component is used as a dropdown list in the following parts of editor:
Closes #582
Test dropdown for control element selection on Configuration panel in virtual mode too. See original issue of #582