Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased timeout when writeBuffer is busy to avoid module drops #547

Merged
merged 31 commits into from
Jan 22, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Jan 7, 2024

Increased Timeout for modules.

Until first review:

  • Comments are left in for checking the intervals between heartbeats (displayed in ms) to more easily settle on a different heartbeat interval.
  • The Timeout was 300ms
  • The usual interval between two heartbeats are around ~250ms
  • In developement enviroment, the modules are dropping during clear with 1600ms elapsing between heartbeats. 2700ms were present for clearing and storing heavier profile cloud profiles.
  • Increased Tiemout to 5000ms to ensure that no drops should occur, eliminating other possibilities for module drop.

TODO:

  • After review remove console.logs
  • Set a proper timeout

@SukuWc
Copy link
Member

SukuWc commented Jan 10, 2024

Test with nightly firmware

@SukuWc SukuWc changed the title Increased timeout for modules to avoid module drops Increased timeout when writeBuffer is busy to avoid module drops Jan 11, 2024
@SukuWc SukuWc merged commit 8b1b1da into stable Jan 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants