Tooling update #536
Merged
Tooling update #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New update to GitHub Actions
Upload and download artifacts are updated to
v4. Now the build artifacts are uploaded/downlaoded separately, no need to wait for all jobs to finish to begin testing. Read more here.MacOS notarytool requires teamId
Although uploaded to github secrets and already added to
notarize.js, theAPPLE_TEAM_IDwas not used in the action scripts. If I remember correctly, I could not use it before as the notarization server was not working when team id was present. Since it's now ultimately required, added back to the scripts.Quit app resulting in crash
This branch uses one of the most recent stable branch. Alpha and nightly builds done on this branch don't have this issue anymore. I suspect that the package tab crash or some other background process crashing resulted in this error, which has been fixed in the meantime by @danim1130.