Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle profile cloud on editor release, allow offline functionality #354

Merged
merged 13 commits into from
Aug 22, 2023

Conversation

danim1130
Copy link
Contributor

When creating a new release, Github Actions will checkout the current profile-cloud repository and build the latest tagged commit. The resulting project will be bundled with the Editor.

If loading the online version of the profile cloud fails, the Editor is able to use the bundled version instead.

  • When no internet connection is available at first start, 'Load Offline' button should be visible in the profile cloud pane
  • Pressing the button will load the bundled profile-cloud version

@narayb
Copy link
Collaborator

narayb commented Aug 17, 2023

I might be misunderstanding this feature, but on the profile cloud sidebar, even when starting in offline there is only a login prompt, nothing else. If offline, I'm unable to log in of course.

@narayb
Copy link
Collaborator

narayb commented Aug 17, 2023

When loading the offline mode, clicking the module after makes the profile cloud sidebar disappear again.
image

@danim1130 danim1130 linked an issue Aug 18, 2023 that may be closed by this pull request
@danim1130
Copy link
Contributor Author

Issue fixed!

@danim1130 danim1130 merged commit 1acd8cf into stable Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BLOCKER] Cached version of profile cloud buldned with editor
2 participants