Fixed clipping and added text truncation for Action blocks #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tested Action Blocks now all truncate text properly and it doesn't affect the placement of text boxes anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On smaller displays, some action blocks input field title is to long to be rendered in one line, causing the misalignment of the layout of these action blocks.
This fix contains the truncation of these titles, meaning when a title is too long, the title will be rendered in the following pattern:
The layout is intact on smaller displays.
A new issue was found during testing, this PR contains the fix for that too.
The issue is that the layout of some action blocks was coded poorly, and the automatic layout resizing had a implicitly defined minimum size. When the width of the Config menu was smaller than this minimum width of the action block, the action block "broke out" of the Config menu. See the following image:
The layout of MIDI MIDI14 and KeyboardMacro action blocks were reworked.