Skip to content

Conversation

@craigds
Copy link

@craigds craigds commented Mar 5, 2013

For much simpler/cleaner code.

I've signed the CLA, though I'm not exactly sure why it's necessary. This pull request contains vendored code authored by @kennethreitz and others, which is already Apache licensed, but they probably haven't signed the CLA (nor should they have to)

cf http://docs.python-requests.org/en/latest/

@intchanter
Copy link
Owner

I love what I see here, but you may have intended to submit this to SeleniumHQ/selenium. I'm not official enough to get this in the main trunk.

On a side note, I submitted a pull request today to add Python 3 support. Hopefully when/if that's accepted it won't require too much reworking of your patch to get it in. I'm excited to see this much higher-level library included and used throughout the code base.

@craigds
Copy link
Author

craigds commented Mar 5, 2013

Yeah, I was hoping you were semi-official. I forked this from your fork because requests also requires python 2.6+, so it kind of depends on your work being accepted.

@intchanter
Copy link
Owner

Go ahead and mention that in your PR to the SeleniumHQ project. My guess
is that AutomatedTester will be the one to review and include it. It
really does look like your changes and mine were made to work with each
other. :-)

How did you find out about my py2+3 changes?

On Tue, Mar 5, 2013 at 11:58 PM, Craig de Stigter
notifications@github.comwrote:

Yeah, I was hoping you were semi-official. I forked this from your fork
because requests also requires python 2.6+, so it kind of depends on your
work being accepted.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-14473862
.

@craigds
Copy link
Author

craigds commented Mar 6, 2013

I just noticed your py3 stuff when checking if anyone had done python-requests support yet, browsing through the open pull requests.

Closing this one, you're right it's up to seleniumhq. I've re-submitted to SeleniumHQ#20 . Cheers

@craigds craigds closed this Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants