don't use mask when native input number is supported #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our mask doesn't support decimal values. Also extend input interface to allow others values to be passed (min, max, patterns, etc)
guilespi
reviewed
May 5, 2017
| @@ -110,7 +110,8 @@ | |||
| (defn- mask-handler-selector | |||
| [target owner state] | |||
| (condp = (:input-format state) | |||
| "numeric" :numeric | |||
| ;; don't use custom mask if native control is supported | |||
| "numeric" (if (utils/browser-support-input-type? "number") :unmasked :numeric) | |||
There was a problem hiding this comment.
no entiendo la utilidad de esto, en que caso el control en clojurescript precisa esta distinción?
There was a problem hiding this comment.
digamos esto no es client-side, es en los navegadores del banco digamos
There was a problem hiding this comment.
claro, nosotros usamos los widgets desde nuestra UI, @fapenia usa su js desde el cliente
|
entonces? para que es este toque?
… On May 5, 2017, at 1:45 PM, Sebastián Moreno ***@***.***> wrote:
@kernelp4nic commented on this pull request.
In src/om_widgets/textinput.cljs:
> @@ -110,7 +110,8 @@
(defn- mask-handler-selector
[target owner state]
(condp = (:input-format state)
- "numeric" :numeric
+ ;; don't use custom mask if native control is supported
+ "numeric" (if (utils/browser-support-input-type? "number") :unmasked :numeric)
claro, nosotros usamos los widgets desde nuestra UI, @fapenia usa su js desde el cliente
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Las condiciones no soportan valores decimales y BG no puede condicionar contra unos porcentajes. Ojo que este repo es público :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our mask doesn't support decimal values. Also extend input interface to allow others values to be passed (min, max, patterns, etc)