Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI warnings #136

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

ianthomas23
Copy link
Contributor

Remove warnings in CI:

  • Replace deprecated mamba-org/provision-with-micromamba with mamba-org/setup-micromamba.
  • Update versions of actions that are using deprecated node12.

@martindurant
Copy link
Member

We seem to be using dtype=np.float or (assert array.dtype == np.float), should be easy to fix.

@ianthomas23
Copy link
Contributor Author

We seem to be using dtype=np.float or (assert array.dtype == np.float), should be easy to fix.

OK, trying that out. Can you approve the CI workflow again please?

@martindurant
Copy link
Member

oh, it seems to be rasterio that is doing this too

@ianthomas23
Copy link
Contributor Author

@martindurant CI workflow needs approval again.

@martindurant
Copy link
Member

There is still one failure there, but I can't immediately tell what the issue is.

@ianthomas23
Copy link
Contributor Author

It looks like test_http_server_files is picking up the changes to glob in the latest fsspec release. I think I've fixed this now.

Needs another workflow approval 😁

@ianthomas23
Copy link
Contributor Author

With Python 3.8 we are using older numpy (3.8 support dropped recently) but new rasterio. So we are essentially debugging rasterio-numpy combinations.

@martindurant
Copy link
Member

Hm, the failure in py38 would be because the newest numpy no longer builds on that version? We could change the supported versions to 3.9-3.11, seems reasonable.

@martindurant
Copy link
Member

Sorry, your comment only just showed up. Let's test 3.9-3.11, but we don't need to change the python_requires as yet (but we could).

@ianthomas23
Copy link
Contributor Author

I have pinned rasterio in the python 3.8 environment file and the tests pass locally so let's try that. Can you approve the workflow yet again?

@martindurant
Copy link
Member

@ianthomas23 , is it too late to make you a member of Intake :)

@ianthomas23
Copy link
Contributor Author

It is too late now, the tests have all passed!

@martindurant martindurant merged commit d0418f7 into intake:master Sep 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants