Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
When the format is "zarr", the path is a local(able) asset and the path endswith ".zip", this adds a case in
source._open_datasetto first ensure a local path, then open azarr.storage.ZipStoreand pass that to xarray.Storage options are dropped from the xarray args as they were already used by fsspec to make the path local.
I must admit that I'm not completely sure of what
ffspec.open_localdoes and I simply implemented this by copying what was done in the other cases.Related issue number
Fixes #769.
Checklist
I think this will not interfere with ZEP8's url pipelines once they are implemented because the
urlpathof a zipped zarr will not end with ".zip", but rather with a series of |-separated parts.