Only use fsspec obj to scan remote csv if polars version is less than 1.34#771
Conversation
… 1.34 - should have been fixed by polars#24450, which was released in 1.34
|
@charles-turner-1 - which PR should I look at first? 😄 |
|
Sorry, it's been a busy morning! This one is pretty straightforward, 767 is quite a bit more complicated - so I'd start here. Is there a way to disable/delay auto-pinging you with every PR I open, short of editing the code owners file? It's probably a bit irritating! |
No worries at all :) I like getting a ping to see the updates! You can always tag as a draft to let me know when it is still not ready, but no pressure/rush!! Thanks for getting these PRs in |
|
I think I did move the other back to draft actually - shame it doesn't cancel the review request with the change 😞 |
mgrover1
left a comment
There was a problem hiding this comment.
Looks good! Makes sense - thanks so much!!
Change Summary
I have tested it against the datastore linked in #744 and can confirm it works for polars 1.33,1.34 and 1.36 (latest).
Memory usage will onIy have reduced if polars >= 1.34.
We could also bump the minimum polars version & keep the code simpler...
Related issue number
#744
#753
Checklist