Skip to content

Only use fsspec obj to scan remote csv if polars version is less than 1.34#771

Merged
charles-turner-1 merged 3 commits intomainfrom
reduce-memory-footprint-open-esm-ds
Jan 9, 2026
Merged

Only use fsspec obj to scan remote csv if polars version is less than 1.34#771
charles-turner-1 merged 3 commits intomainfrom
reduce-memory-footprint-open-esm-ds

Conversation

@charles-turner-1
Copy link
Collaborator

@charles-turner-1 charles-turner-1 commented Jan 9, 2026

Change Summary

I have tested it against the datastore linked in #744 and can confirm it works for polars 1.33,1.34 and 1.36 (latest).

Memory usage will onIy have reduced if polars >= 1.34.

We could also bump the minimum polars version & keep the code simpler...

Related issue number

#744
#753

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

… 1.34 - should have been fixed by polars#24450, which was released in 1.34
@mgrover1
Copy link
Collaborator

mgrover1 commented Jan 9, 2026

@charles-turner-1 - which PR should I look at first? 😄

@charles-turner-1
Copy link
Collaborator Author

Sorry, it's been a busy morning! This one is pretty straightforward, 767 is quite a bit more complicated - so I'd start here.

Is there a way to disable/delay auto-pinging you with every PR I open, short of editing the code owners file? It's probably a bit irritating!

@mgrover1
Copy link
Collaborator

mgrover1 commented Jan 9, 2026

Sorry, it's been a busy morning! This one is pretty straightforward, 767 is quite a bit more complicated - so I'd start here.

Is there a way to disable/delay auto-pinging you with every PR I open, short of editing the code owners file? It's probably a bit irritating!

No worries at all :) I like getting a ping to see the updates! You can always tag as a draft to let me know when it is still not ready, but no pressure/rush!! Thanks for getting these PRs in

@charles-turner-1
Copy link
Collaborator Author

I think I did move the other back to draft actually - shame it doesn't cancel the review request with the change 😞

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Makes sense - thanks so much!!

@charles-turner-1 charles-turner-1 merged commit 89e7fde into main Jan 9, 2026
9 checks passed
@charles-turner-1 charles-turner-1 deleted the reduce-memory-footprint-open-esm-ds branch January 9, 2026 03:49
@charles-turner-1 charles-turner-1 mentioned this pull request Jan 9, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in Polars when loading ESM catalog from S3-hosted CSV (begin <= end (10 <= 9) slicing error)

2 participants