Added a function to search the time_ranges of the catalog#291
Open
wachsylon wants to merge 2 commits intointake:mainfrom
Open
Added a function to search the time_ranges of the catalog#291wachsylon wants to merge 2 commits intointake:mainfrom
wachsylon wants to merge 2 commits intointake:mainfrom
Conversation
Member
|
@wachsylon, Thank you for your patience and putting this PR together! Since it's been a while since you submitted this PR, I was wondering if this is something you are still interested in? I am asking because I think this is very useful functionality and would like to work with you to make it generic enough (the current implementation is a bit specific and tends to cover a limited number of use cases). |
Author
|
Hi @andersy005 ,
cool.
What do you have in mind? Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am a scientific programmer at DKRZ and I really appreciate intake and intake-esm for the purpose of finding and accessing data.
An issue related to the subsetting in time ranges in the
time_rangecolumn of CMIP catalogs is that the length of the string values vary. This code of this PR allows to search for all data that covers a time range defined by two time strings.We think that this will be very beneficial when working with CMIP catalogs.
A colleague of mine (Ludwig Lierhammer) has written this code snippet and asked me to share it.
I think the best place to implement that would be in your software in search.py so I tried to implement it there.
I tested the function itself however I do not know how to best call it in the intake workflow. Therefore, I do not have a test.
I am a beginner in python software managing. I try to follow your steps but I do also have not much time for caring for all the pull request tests especially since this code snippet needs some adaption.
And, an additonal comment:
I think that these 10 steps for a simple contribution to the repo takes too much time for an external programmer who has not much experience. This does not help if it is your intention to motivate the community to contribute to the repo. Idk how other repos handle it and I do understand that it is a part of guaranteeing stable code. For me, it is frustrating.
Cant that be done by automized CI tests?
Best regards,
Fabi