Skip to content

Add codegen check to CI #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add codegen check to CI #240

wants to merge 6 commits into from

Conversation

turtletongue
Copy link

@turtletongue turtletongue commented Jul 9, 2025

Resolves #239

Synopsis

Code generation is being done manually and it can lead to merging out-of-sync Dart bindings.

Solution

A new codegen check is added to CI that runs make cargo.gen and makes sure that there were no file changes during this process.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@turtletongue turtletongue self-assigned this Jul 9, 2025
@turtletongue turtletongue added k::toolchain Applies to changes of project toolchain feature New feature or request k::testing Related to testing and/or automated tests labels Jul 9, 2025
@turtletongue turtletongue force-pushed the add-codegen-ci-step branch from c45371f to f194b38 Compare July 9, 2025 16:50
@turtletongue
Copy link
Author

turtletongue commented Jul 10, 2025

FCM

Add `codegen` check stage to CI (#240, #239) 

@turtletongue turtletongue marked this pull request as ready for review July 10, 2025 14:00
@turtletongue turtletongue requested a review from evdokimovs July 10, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request k::testing Related to testing and/or automated tests k::toolchain Applies to changes of project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cargo.gen check stage to medea-flutter-webrtc CI
1 participant