Skip to content

Move RtcRtpEncodingParameters into separate module #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

turtletongue
Copy link

@turtletongue turtletongue commented Jun 30, 2025

Part of #210

Synopsis

RtcRtpEncodingParameters is defined in the native API module with unrelated logic.

Solution

RtcRtpEncodingParameters should be moved inside a new rtc_rtp_encoding_parameters submodule.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@turtletongue
Copy link
Author

turtletongue commented Jun 30, 2025

FCM

Move `RtcRtpEncodingParameters` into a submodule in `medea-flutter-webrtc-native` crate (#210, #223)

@turtletongue turtletongue marked this pull request as ready for review June 30, 2025 12:57
@turtletongue turtletongue marked this pull request as draft July 3, 2025 14:55
@turtletongue turtletongue force-pushed the separate-rtc-rtp-encoding-parameters branch from 61ea988 to f96d24f Compare July 4, 2025 12:16
@turtletongue turtletongue marked this pull request as ready for review July 4, 2025 12:25
@turtletongue turtletongue added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::api Related to API (application interface) labels Jul 9, 2025
@turtletongue turtletongue self-assigned this Jul 9, 2025
@turtletongue turtletongue requested a review from evdokimovs July 9, 2025 16:13
@evdokimovs evdokimovs requested a review from alexlapa July 11, 2025 10:53
@alexlapa alexlapa requested a review from tyranron July 11, 2025 14:56
@tyranron tyranron enabled auto-merge (squash) July 14, 2025 10:33
@tyranron tyranron merged commit 1cbfaa8 into instrumentisto:main Jul 14, 2025
45 of 52 checks passed
@tyranron tyranron removed the k::api Related to API (application interface) label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants