forked from flutter-webrtc/flutter-webrtc
-
Notifications
You must be signed in to change notification settings - Fork 3
Move RtcRtpEncodingParameters into separate module #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tyranron
merged 12 commits into
instrumentisto:main
from
turtletongue:separate-rtc-rtp-encoding-parameters
Jul 14, 2025
Merged
Move RtcRtpEncodingParameters into separate module #223
tyranron
merged 12 commits into
instrumentisto:main
from
turtletongue:separate-rtc-rtp-encoding-parameters
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCM
|
61ea988
to
f96d24f
Compare
….com/turtletongue/medea-flutter-webrtc into separate-rtc-rtp-encoding-parameters
evdokimovs
approved these changes
Jul 11, 2025
alexlapa
approved these changes
Jul 11, 2025
tyranron
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #210
Synopsis
RtcRtpEncodingParameters
is defined in the native API module with unrelated logic.Solution
RtcRtpEncodingParameters
should be moved inside a newrtc_rtp_encoding_parameters
submodule.Checklist
k::
labels applied