Skip to content

Refactor pub fields in tracks #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 26, 2025
Merged

Refactor pub fields in tracks #208

merged 7 commits into from
Jun 26, 2025

Conversation

turtletongue
Copy link

@turtletongue turtletongue commented Jun 25, 2025 •
edited by tyranron
Loading

Resolves #207
Part of #206

Synopsis

Fields id, source, track_events_tx and senders are public. It's an antipattern and makes refactoring difficult.

Solution

Expose getters for id and source and add methods for managing senders to tracks.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@turtletongue
Copy link
Author

FCM

Change visibility of partial-pub fields in AudioTrack and VideoTrack (#208)

@turtletongue turtletongue marked this pull request as ready for review June 25, 2025 12:54
evdokimovs
evdokimovs requested changes Jun 25, 2025
View reviewed changes
@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Jun 25, 2025
@evdokimovs
Copy link

evdokimovs commented Jun 25, 2025 •
edited by tyranron
Loading

FCM

Change visibility of partial-pub fields in AudioTrack and VideoTrack (#208)

FCM

Make all fields of `AudioTrack`/`VideoTrack` private in `medea-flutter-webrtc-native` crate (#208, #207, #206)

@turtletongue ,

Use backticks to format technical names.

@evdokimovs evdokimovs requested a review from alexlapa June 25, 2025 14:28
@alexlapa alexlapa requested a review from tyranron June 26, 2025 10:48
@tyranron tyranron merged commit 0edfe56 into instrumentisto:main Jun 26, 2025
46 of 50 checks passed
turtletongue added a commit to turtletongue/medea-flutter-webrtc that referenced this pull request Jul 3, 2025
@turtletongue
Make all fields of AudioTrack/VideoTrack private in `medea-flutte…
884e8fc 
…r-webrtc-native` crate (instrumentisto#208, instrumentisto#207, instrumentisto#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

@evdokimovs evdokimovs evdokimovs approved these changes

Assignees

@turtletongue turtletongue

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose getters for partial-pub fields in AudioTrack and VideoTrack
4 participants
@turtletongue @evdokimovs @tyranron @alexlapa