-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(many): border colors are adjusted to meet a11y contrast standards #1743
base: master
Are you sure you want to change the base?
Conversation
background: componentTheme.toggleBackground, | ||
boxShadow: componentTheme.toggleShadow, | ||
borderRadius: '100%' | ||
borderRadius: '100%', | ||
border: componentTheme.borderWidth + ' solid', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can write this a bit simpler:
const { borderWidth, uncheckedIconBorderColor, checkedIconBorderColor} = componentTheme
...
border: `${borderWidth} solid ${checked ? 'checkedIconBorderColor' : 'uncheckedIconBorderColor'}`,
@@ -1377,6 +1377,10 @@ class Drilldown extends Component<DrilldownProps, DrilldownState> { | |||
getDisabledOptionProps | |||
}) => ( | |||
<View | |||
themeOverride={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use themeOverride
for our own components
@@ -1418,6 +1422,9 @@ class Drilldown extends Component<DrilldownProps, DrilldownState> { | |||
})} | |||
> | |||
<View | |||
themeOverride={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use themeOverride
for our own components
return ( | ||
<ContextView | ||
{...viewProps} | ||
themeOverride={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use themeOverride
for our own components
return ( | ||
<View | ||
{...viewProps} | ||
themeOverride={{ borderColorPrimary: styles?.borderColor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use themeOverride
for our own components
@@ -162,6 +174,7 @@ class ToggleGroup extends Component<ToggleGroupProps> { | |||
display="block" | |||
borderRadius="medium" | |||
background="primary" | |||
themeOverride={{ borderColorPrimary: styles?.borderColor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use themeOverride
for our own components
Closes: INSTUI-4319
cf7f0c8
to
b560405
Compare
|
Closes: INSTUI-4319
TEST PLAN: