fix(many): border colors are adjusted to meet a11y contrast standards #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balzss
requested changes
Oct 18, 2024
| background: componentTheme.toggleBackground, | ||
| boxShadow: componentTheme.toggleShadow, | ||
| borderRadius: '100%' | ||
| borderRadius: '100%', | ||
| border: componentTheme.borderWidth + ' solid', |
There was a problem hiding this comment.
you can write this a bit simpler:
const { borderWidth, uncheckedIconBorderColor, checkedIconBorderColor} = componentTheme
...
border: `${borderWidth} solid ${checked ? 'checkedIconBorderColor' : 'uncheckedIconBorderColor'}`,
| @@ -1377,6 +1377,10 @@ class Drilldown extends Component<DrilldownProps, DrilldownState> { | |||
| getDisabledOptionProps | |||
| }) => ( | |||
| <View | |||
| themeOverride={{ | |||
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| @@ -1418,6 +1422,9 @@ class Drilldown extends Component<DrilldownProps, DrilldownState> { | |||
| })} | |||
| > | |||
| <View | |||
| themeOverride={{ | |||
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| return ( | ||
| <ContextView | ||
| {...viewProps} | ||
| themeOverride={{ |
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| return ( | ||
| <View | ||
| {...viewProps} | ||
| themeOverride={{ borderColorPrimary: styles?.borderColor }} |
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
| @@ -162,6 +174,7 @@ class ToggleGroup extends Component<ToggleGroupProps> { | |||
| display="block" | |||
| borderRadius="medium" | |||
| background="primary" | |||
| themeOverride={{ borderColorPrimary: styles?.borderColor }} | |||
There was a problem hiding this comment.
we shouldn't use themeOverride for our own components
Closes: INSTUI-4319
ToMESSKa
force-pushed
the
INSTUI-4319_fix_border_contrast_a_11_y_issues
branch
from
cf7f0c8
to
b560405
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4319
TEST PLAN: