Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): add support for bundler 2.6, drop support for EOL Rubies, update gems #51

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rafasoares
Copy link

I tried to simply bump bundler version to accept 2.6, but I kept running into issues related to the support for Ruby 2.6, so I decided to simply drop support for EOL versions of Ruby.

It doesn't really make sense for a given version of this plugin to support both EOL and modern Ruby.

I've had to change the specs, as ddtrace doesn't support Ruby 3.4. I've replaced it with their newer gem, datadog, while trying to keep the same test behavior.

@rafasoares rafasoares marked this pull request as ready for review February 18, 2025 11:57
@rmsy rmsy requested a review from ccutrer February 18, 2025 15:15
@rafasoares
Copy link
Author

Converting to draft while I fix the tests locally.

@rafasoares rafasoares marked this pull request as draft February 19, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant