Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PathService.tsx #280

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

samarpita-bhaumik
Copy link
Contributor

Issue: Taxonomy Directory Path dropdown QOL #218
solved: Dropdown menu closed when field is clicked away from.

Signed-off-by: Samarpita Bhaumik <samarpitabhaumik2017@gmail.com>
Signed-off-by: Samarpita Bhaumik <samarpitabhaumik2017@gmail.com>
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@nerdalert nerdalert merged commit 82a4580 into instructlab:main Oct 20, 2024
6 checks passed
@vishnoianil
Copy link
Member

@samarpita-bhaumik can you please cherry-pick this to release-1.0 branch as well.

@vishnoianil vishnoianil added the cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch. label Oct 21, 2024
@samarpita-bhaumik
Copy link
Contributor Author

@vishnoianil sure i will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants