Add the ilab-public org signup link to the login page #278
Conversation
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
| style={{ backgroundColor: 'black' }} | ||
| onClick={handleSignUpClick} | ||
| > | ||
| Sign up |
There was a problem hiding this comment.
| Sign up | |
| Join the beta (required) |
There was a problem hiding this comment.
This wording isn't perfect since they're technically joining an org, but for now this would indicate to the user that this is a "beta" and that clicking this button is also required (just once) until we improve this flow in the future.
| icon={<CustomLogoIcon />} | ||
| iconPosition="left" | ||
| size="lg" | ||
| style={{ backgroundColor: 'black' }} |
There was a problem hiding this comment.
| style={{ backgroundColor: 'black' }} | |
| style={{ backgroundColor: '#24274e' }} |
Quick hack to make this slightly less primary-looking (only required once).
| @@ -32,11 +47,21 @@ const GithubLogin: React.FC = () => { | |||
| icon={<GithubIcon />} | |||
| iconPosition="left" | |||
| size="lg" | |||
| style={{ backgroundColor: 'black' }} | |||
| style={{ backgroundColor: 'black', marginRight: '20px' }} | |||
There was a problem hiding this comment.
Mind flipping the order of these buttons so that "Sign in with GitHub" is on the right instead?
For left-to-right readers, placing the one-time/required button on the left will make it likelier to be noticed and clicked on first. Hopefully in the future we won't need two buttons, but reordering would work as a quick improvement for now.
|
@nerdalert As per our discussion, based on your inviter code, i created this PR. #282 @andybraren Please take a look at the PR. @nerdalert and myself did some brainstorming around this and decided that we should ask user to login, and once authenticated with the github, if user is not part of the instructlab-public org, show a popup to join the organization. Pop up has button to self-invite, and once user accept the invitation it can access the UI. So user doesn't have to worry about any invited link or password. |
|
Nice! That's even more streamlined. 👍 |
Screencap:
Tracked in #277