Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Page: Update with Sorted Table, Add Empty States to Table #259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhuje
Copy link

@zhuje zhuje commented Oct 10, 2024

Related to issue(s)

#96

Overview:

This is a PR that addresses only the Submissions page.

    1. Convert the current Dashboard Page from using Cards [1] to using the PatternFly Sortable Responsive Table [2]
    1. Add Empty States to the Table (Loading, and Unable to connect). 'No Results' page is not in this PR because the Filters were not included.

Before:

DashboardTableBefore Figure 1. Dashboard Page with mocked response. Rows are displayed using Card components.

After

instructLab_PR259_TableData Figure 2. Display data using PatternFly Sortable Responsive Table
instructLab_PR259_error Figure 3. Table Data: Error
instructLab_PR259_loading Figure 4. Table Data: Loading

@zhuje zhuje marked this pull request as draft October 10, 2024 04:29
@zhuje zhuje mentioned this pull request Oct 10, 2024
@vishnoianil
Copy link
Member

@zhuje If you are still having issue for github authentication setup, please ping me on slack, and i am happy to debug it with you.

Also please fix the UI lint (run npm run lint:fix locally) and signoff the commits, so the DCO jobs will pass.

Once you login with the github, you will see that we have the empty state. Pushed through the following PR#176. Please review the existing empty state page and see if there are any gaps that needs to be address.

Progress on 1) looks great to me. Thanks for the mockups. @Misjohns Please review the mockups and share your thoughts.

@Misjohns
Copy link
Collaborator

Thank you @zhuje looking good. We probably could use PF status icons for status but we don't need anything for created and updated.

@zhuje
Copy link
Author

zhuje commented Oct 22, 2024

@Misjohns I left the icons in there by accident, those where from the Patternfly template for responsive tables. I'll remove the icons from the created and updated columns.

I might leave out the attribute search/text filtering in this iteration of the Table. It's adding a bit of complexity that is growing the PR.

We can add the attribute search/text filtering as a separate feature in the future if you still want to proceed with that. WDYT?

Sorry, about the slowed progress, I have some other priorities that took my attention. I'm still continuing with the work on this PR.

@Misjohns
Copy link
Collaborator

Agree, we can add the search at a later time.

@zhuje zhuje force-pushed the issue_96_empty_state_dashboards branch from e40b13b to 0daf328 Compare November 4, 2024 16:20
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
@zhuje zhuje force-pushed the issue_96_empty_state_dashboards branch from 0daf328 to fab9e0c Compare November 4, 2024 16:21
@zhuje zhuje marked this pull request as ready for review November 4, 2024 16:30
@zhuje zhuje changed the title [DRAFT] Dashboard Page: Update with Sorted Table, Add Empty States to Table Dashboard Page: Update with Sorted Table, Add Empty States to Table Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants