-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI assistants to determine if the context of the conversation #787
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
You will also need to sign off on your commits as outlined here |
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
@instructlab-bot precheck |
Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 277. The results will be presented below in the pull request status box. This may take several minutes... |
Results for job ID: 277 using the model merlinite-7b! Results can be found here. |
Hello @mingxzhao I can see the commits are signed off already. Eg: "Signed-off-by: Hugo Carlos Calero Díaz 112875627+Hugo-Calero@users.noreply.github.com". Is there anything else I need to do? |
Ah apologies I seemed to have missed that. If you could just update the attribution file and fix the linting issues, I can approve! It seems there are some spacing issues in your file. |
Hello! I have checked the listing in https://www.yamllint.com, and I see no error, is there any specific guideline I need to follow or recommended software to check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the linting issues.
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
Hi, I commited modifications to the yaml file, I hope there are no spacing issues now. Please review! Many thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linting issue.
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
@instructlab-bot precheck |
Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 324. The results will be presented below in the pull request status box. This may take several minutes... |
Results for job ID: 324 using the model instructlab/granite-7b-lab! Results can be found here. |
Hello, I see the merging is still blocked. Is there anything left to do on my side? I already fixed the linting issues I identified, I hope I didn't miss any. |
@instructlab-bot generate |
Beep, boop 🤖, Generating test data for your PR with the job type: sdg-svc. Your Job ID is 346. The results will be presented below in the pull request status box. This may take several minutes... |
Looking at the precheck it seems to be very far off the rails which is good for this PR. Now the SDG generate will give us an understanding of the data that is generated and if it will add possible value to the model. Assuming it does, then we will tag it as approved, and it will be upstreamed, then we will see from the engineering team if the model improves, only then we will merge. |
Results for job ID: 346 using the model sdg service backend! Results can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the version: 2
then we are ready the next steps.
compositional_skills/linguistics/Conversation_orchestration/identify_different_themes/qna.yaml
Show resolved
Hide resolved
Signed-off-by: Hugo Carlos Calero Díaz <112875627+Hugo-Calero@users.noreply.github.com>
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands. |
@instructlab-bot precheck |
Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 362. The results will be presented below in the pull request status box. This may take several minutes... |
Results for job ID: 362 using the model instructlab/granite-7b-lab! Results can be found here. |
With what I read through the |
It does seem to get several of the answers wrong when compared to the user provided answers. I think this could be a good skill, but the context part of the question may need to be placed in the "context" field of the yaml for good SDG. At the moment there does seem to be several wrong answers though. |
Wait really? I thought the precheck answer what we wanted. That it knew the questions didn't match the context, for instance: https://instruct-lab-bot.s3.us-east-2.amazonaws.com/precheck-pr-787-1dee610dbcdeb1f9cc76357c360aa8e63ebd1e8c-job-362/chat_2024-06-03T21_21_14.log
|
Not quite, the question is about whether the following provided question is in the same context as the previous provided questions. The model seems to have difficulty parsing this and even answers the question separately from the context entirely. |
Hi, is there anything I can do to advance the status of this contribution? |
We are in progress here. I believe we need this to be put in the next run, updates will be added to the PR as they arrive. |
Hi! 👋 We are thankful for your patience and ask that you please keep this PR open. As soon as we finish all our behind-the-scenes work, we’ll test the full model against your submissions and, ideally, accept your amazing contribution(s)! Your Community Maintainer Team. P.S. if you have any specific questions or thoughts, don’t hesitate to comment on pull request this or email awesome@instructlab.ai and lhawthor@redhat.com, and we’ll get back to you as soon as possible. |
@mcorbin-ibm where should this one live? |
I think that this applies more to the "AI" side of things than "linguistics" and after doing some research in Wikipedia, in conjunction with our Dewey Decimal System reference document, I recommend placing this here in the taxonomy:
Note: I did not see a context specified in the qna, so I did not put this under the |
If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy
Input given at the prompt
Response from the original model
Response from the fine-tuned model
Contribution checklist
ilab generate
ilab generate
qna.yaml
file contains at least 5seed_examples
qna.yaml
file was linted and prettified (yaml-validator can do both)attribution.txt
file in the same folder as theqna.yaml
file