Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: Confirm the qna.yaml file has a non-empty attribution.txt #757

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

bjhargrave
Copy link
Contributor

After validating the qna.yaml, we also confirm the presence of a non-empty attribution.txt file in the same folder.

After validating the qna.yaml, we also confirm the presence of a
non-empty attribution.txt file in the same folder.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@github-actions github-actions bot added the ci label Apr 23, 2024
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 yay!

@bjhargrave bjhargrave merged commit 170643d into instructlab:main Apr 24, 2024
2 checks passed
@bjhargrave bjhargrave deleted the confirm-attribution-txt branch April 24, 2024 18:11
jjasghar pushed a commit to luke-inglis/taxonomy that referenced this pull request Jun 7, 2024
…instructlab#757)

After validating the qna.yaml, we also confirm the presence of a
non-empty attribution.txt file in the same folder.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants