Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill: semantic version comparison and filtering #628

Closed
wants to merge 1 commit into from

Conversation

TomasHofman
Copy link

@TomasHofman TomasHofman commented Mar 25, 2024

Describe the contribution to the taxonomy

Improves filtering and ordering of versions strings.

Input given at the prompt

>>> Print version strings from following list that belong to major version 1.x:

    2.0.1
    3.0.6
    1.5.6
    1.0.8
    0.3.1
    11.0.0
    0.128.3.6
>>> Order following version strings from lowest to highest:
 
    2.0.1
    3.0.6
    1.5.6
    1.0.8
    0.3.1
    11.0.0
    0.128.3.6

Response from the original model

╭─────
│ Here is the list with version strings that belong to major version 1.x:  
│ 1.0.8                                                                    
│ 11.0.0                                                                   
╰─────

(Wrong version included.)

╭─────
│ Here is the list with version strings ordered from lowest to highest: 
 |
│ 0.128.3.6
│ 0.3.1
│ 1.0.8
│ 1.5.6
│ 2.0.1
│ 11.0.0
╰─────

(Version 3.0.6 is missing.)

Response from the fine-tuned model

Not able to do the training on my HW.

Contribution checklist

@TomasHofman TomasHofman requested a review from a team as a code owner March 25, 2024 15:52
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged skill (Auto labeled) labels Mar 25, 2024
@TomasHofman TomasHofman force-pushed the version-comparison branch 4 times, most recently from 78a36ce to dd88f6d Compare March 26, 2024 07:58
Signed-off-by: Tomas Hofman <thofman@redhat.com>
Copy link
Member

@mingxzhao mingxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistencies in some ordering.

3.2.5-Alpha
3.2.5-Beta
3.2.5-CR3
3.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whereas seems to indicate 3.2.5-final is higher than 3.2.5

4.14.14
4.12.10
4.6.6
4.6.6-Final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to indicate 4.6.6 is higher than 4.6.6 final

6.11.10.Alpha
6.11.10-CR2
6.11.10-CR3
6.11.10.Final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here

12.14.10.Alpha
12.14.10-Beta
12.14.10-CR3
12.14.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@mingxzhao mingxzhao added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels Apr 5, 2024
@jjasghar jjasghar closed this Apr 19, 2024
@n1hility
Copy link
Member

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:

https://forms.gle/V7SrPPMZDo6iGDYu8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants