-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skill: semantic version comparison and filtering #628
Conversation
78a36ce
to
dd88f6d
Compare
Signed-off-by: Tomas Hofman <thofman@redhat.com>
dd88f6d
to
0aa1e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistencies in some ordering.
3.2.5-Alpha | ||
3.2.5-Beta | ||
3.2.5-CR3 | ||
3.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whereas seems to indicate 3.2.5-final is higher than 3.2.5
4.14.14 | ||
4.12.10 | ||
4.6.6 | ||
4.6.6-Final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to indicate 4.6.6 is higher than 4.6.6 final
6.11.10.Alpha | ||
6.11.10-CR2 | ||
6.11.10-CR3 | ||
6.11.10.Final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
12.14.10.Alpha | ||
12.14.10-Beta | ||
12.14.10-CR3 | ||
12.14.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested: |
Describe the contribution to the taxonomy
Improves filtering and ordering of versions strings.
Input given at the prompt
Response from the original model
(Wrong version included.)
(Version 3.0.6 is missing.)
Response from the fine-tuned model
Not able to do the training on my HW.
Contribution checklist
lab generate
lab generate
qna.yaml
file contains at least 5seed_examples
qna.yaml
file was linted and prettified (yaml-validator can do both)