-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skill to draft a LinkedIn profile summary #394
Conversation
Signed-off-by: Avinash Singh <avsingh@redhat.com>
Signed-off-by: Avinash Singh <avsingh@redhat.com>
Signed-off-by: Avinash Singh <avsingh@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be split into 3 separate PRs so each can be individually evaluated.
Signed-off-by: Avinash Singh <avsingh@redhat.com>
@bjhargrave As per your suggestions, I have split this PR into three. Also added additional seed_examples as per new checks. |
LinkedIn profile summary / bio seems to be referring to the same thing, and this PR looks a lot like #458 (not identical, but overlap). Suggest to combine the 2 PRs. |
Signed-off-by: Avinash Singh <avsingh@redhat.com>
Hi, there are still multiple qna.yaml files in this PR. Please submit a PR per skill (qna.yaml). Thanks! |
@bjhargrave Not sure how to move ahead with this. Do you want me to put a separate PR for LinkedIn Bio and keep LinkedIn profile summary in this PR? |
yeah I meant to merge both into one skill, since LinkedIn profile summary / bio seems to be referring to the same thing - "The LinkedIn summary, also referred to as the LinkedIn bio or LinkedIn about section..." |
That is fine. We want a single skill per PR so we can evaluate independently and perhaps merge one but not the other. |
Or merging into a single skill is also a reasonable choice. |
Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested: |
If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy
I was unable to serve/run the model as I have an Intel Mac which doesn't have GPU.
Contribution checklist
lab generate
lab generate
qna.yaml
file was linted and prettified (yaml-validator can do both)