Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skill to draft a LinkedIn profile summary #394

Closed
wants to merge 9 commits into from

Conversation

avinashsingh77
Copy link

@avinashsingh77 avinashsingh77 commented Mar 12, 2024

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

  • Adds skill to draft a LinkedIn profile summary.

I was unable to serve/run the model as I have an Intel Mac which doesn't have GPU.

Contribution checklist

Signed-off-by: Avinash Singh <avsingh@redhat.com>
@avinashsingh77 avinashsingh77 requested a review from a team as a code owner March 12, 2024 12:46
Avinash Singh added 2 commits March 12, 2024 18:21
Signed-off-by: Avinash Singh <avsingh@redhat.com>
Signed-off-by: Avinash Singh <avsingh@redhat.com>
@avinashsingh77 avinashsingh77 changed the title Add skill for palindrome strings Add skill for LinkedIn Bio, profile summary and palindrome strings Mar 12, 2024
Copy link
Contributor

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split into 3 separate PRs so each can be individually evaluated.

@bjhargrave bjhargrave added the triage-requested-changes skill has been reviewed; changes requested from contributor label Mar 12, 2024
avinashsingh77 and others added 2 commits March 13, 2024 16:42
Signed-off-by: Avinash Singh <avsingh@redhat.com>
@avinashsingh77 avinashsingh77 changed the title Add skill for LinkedIn Bio, profile summary and palindrome strings Add skill for LinkedIn profile summary Mar 13, 2024
@avinashsingh77
Copy link
Author

@bjhargrave As per your suggestions, I have split this PR into three.
This PR has only one skill( for LinkedIn Profile Summary)
#459 - For Palindrome srings
#458 - For LinkedIn Bio.

Also added additional seed_examples as per new checks.

@avinashsingh77 avinashsingh77 changed the title Add skill for LinkedIn profile summary Add skill to draft a LinkedIn profile summary Mar 13, 2024
@cybette
Copy link
Member

cybette commented Mar 13, 2024

LinkedIn profile summary / bio seems to be referring to the same thing, and this PR looks a lot like #458 (not identical, but overlap). Suggest to combine the 2 PRs.

@avinashsingh77 avinashsingh77 requested a review from a team as a code owner March 14, 2024 10:57
Signed-off-by: Avinash Singh <avsingh@redhat.com>
@avinashsingh77
Copy link
Author

@cybette Added linkedi_bio from #458 to this PR.
Is this okay? Or you meant to combine linkedin bio and profile summary as 1 skill?

@mairin mairin added the skill (Auto labeled) label Mar 16, 2024
@ckadner ckadner added triage-follow-up and removed triage-requested-changes skill has been reviewed; changes requested from contributor labels Mar 27, 2024
@bjhargrave
Copy link
Contributor

Hi, there are still multiple qna.yaml files in this PR. Please submit a PR per skill (qna.yaml). Thanks!

@bjhargrave bjhargrave added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-follow-up labels Mar 27, 2024
@avinashsingh77
Copy link
Author

@bjhargrave Not sure how to move ahead with this.
@cybette Suggested to merge both skills in on PR as they are similar.

Do you want me to put a separate PR for LinkedIn Bio and keep LinkedIn profile summary in this PR?

@cybette
Copy link
Member

cybette commented Apr 11, 2024

yeah I meant to merge both into one skill, since LinkedIn profile summary / bio seems to be referring to the same thing - "The LinkedIn summary, also referred to as the LinkedIn bio or LinkedIn about section..."

@bjhargrave
Copy link
Contributor

Do you want me to put a separate PR for LinkedIn Bio and keep LinkedIn profile summary in this PR?

That is fine. We want a single skill per PR so we can evaluate independently and perhaps merge one but not the other.

@bjhargrave
Copy link
Contributor

yeah I meant to merge both into one skill,

Or merging into a single skill is also a reasonable choice.

@jjasghar jjasghar closed this Apr 19, 2024
@n1hility
Copy link
Member

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:

https://forms.gle/V7SrPPMZDo6iGDYu8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants