fix(iterator): always initialize pipeline output template #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because - Streameed executions with iterators failed because the `_output` key wasn't set in the iterator's child workflow memory. This is initialized on `InitComponentsActivity`, which is run only on parent workflows. This commit - Intializes this field on workflow memory creation. `ComponentActivity` will use it to update the (child) pipeline output at the end of the sub-component execution.
jvallesm
pushed a commit
that referenced
this pull request
Apr 16, 2025
🤖 I have created a release *beep* *boop* --- ## [0.52.2-beta](v0.52.1-beta...v0.52.2-beta) (2025-04-10) ### Bug Fixes * **iterator:** always initialize pipeline output template ([#997](#997)) ([3020465](3020465)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
_outputkeywasn't set in the iterator's child workflow memory. This is
initialized on
InitComponentsActivity, which is run only on parentworkflows.
This commit
ComponentActivitywill use it to update the (child) pipeline output at the end of the
sub-component execution.