Skip to content

fix(repository): fix edition filter #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Dec 4, 2024

Because

  • we need to filter the integration table based on the edition.

This commit

  • fixes the edition filter.
  • removes the filter for instill-app component as it has been already removed.

@donch1989 donch1989 merged commit 634cacd into main Dec 4, 2024
11 checks passed
@donch1989 donch1989 deleted the huitang/fix-edition-filter branch December 4, 2024 07:10
donch1989 pushed a commit that referenced this pull request Dec 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.48.3-beta](v0.48.2-beta...v0.48.3-beta)
(2024-12-04)


### Bug Fixes

* **repository:** fix edition filter
([#921](#921))
([634cacd](634cacd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@@ -878,6 +874,11 @@ func (r *repository) ListIntegrations(ctx context.Context, p ListIntegrationsPar
Where(where, whereArgs...).
Where("is_visible IS TRUE AND has_integration IS TRUE")

if config.Config.Server.Edition == config.EditionCloudStaging || config.Config.Server.Edition == config.EditionCloudProd {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I missed the integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants