-
Notifications
You must be signed in to change notification settings - Fork 22
perf(component,operator,document): optimize unit tests and fix LibreOffice dependency failures #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffice dependency failures
pinglin
added a commit
to instill-ai/instill-core
that referenced
this pull request
Sep 18, 2025
Because - The version of the pipeline-backend service is not updated in the instill-core repository. This commit - updates the `PIPELINE_BACKEND_VERSION` in the `.env` file to `19480ec`. - updates the `pipelineBackend.image.tag` in the helm chart values.yaml file to `19480ec`. ## Changes in pipeline-backend - perf(component,operator,document): optimize unit tests and fix LibreOffice dependency failures (instill-ai/pipeline-backend#1110) - perf(component,operator,video): optimize unit test performance by 59.7% (instill-ai/pipeline-backend#1109) - perf(component,operator,image): optimize unit tests for 98.5% faster … (instill-ai/pipeline-backend#1107) - ci(docker): optimize Dockerfiles with multi-stage builds for faster build times (instill-ai/pipeline-backend#1108) - perf(data): implement automatic field naming convention detection with LRU caching (instill-ai/pipeline-backend#1105) - feat(component,ai,gemini): enhance streaming to output all fields (instill-ai/pipeline-backend#1106) - fix(component,ai,gemini): correct text-based documents logic (instill-ai/pipeline-backend#1103) - test(component,generic,http): replace external httpbin.org dependency with local test server (instill-ai/pipeline-backend#1101) - ci(docker): add GitHub fallback for ffmpeg installation (instill-ai/pipeline-backend#1102) - chore(main): release 0.60.0 (instill-ai/pipeline-backend#1086) - chore(ce): release v0.60.0 (instill-ai/pipeline-backend#1099) - fix(component,ai,instillmodel): resolve panics and test failures (instill-ai/pipeline-backend#1100) - fix(usage): treat input rendering error as fatal (instill-ai/pipeline-backend#1098) - refactor(component,ai,gemini): enhance document processing with text … (instill-ai/pipeline-backend#1097) - ci(gitignore): ignore .cursor folder (instill-ai/pipeline-backend#1096) - fix(component,ai,instillmodel): fix outdated data struct (instill-ai/pipeline-backend#1095) - chore(component,ai): remove unused files (instill-ai/pipeline-backend#1094) - chore(data,component,gemini): improve error msg (instill-ai/pipeline-backend#1093) - chore(component,gemini): optimize the IO struct (instill-ai/pipeline-backend#1092) - fix(recipe): support nil, null, undefined for condition field (instill-ai/pipeline-backend#1091) Co-authored-by: pinglin <628430+pinglin@users.noreply.github.com>
pinglin
added a commit
that referenced
this pull request
Sep 18, 2025
…ffice dependency failures (#1110) Because - Unit tests were failing with LibreOffice exit status 77 errors when external dependencies were missing - Test execution was extremely slow due to repeated file I/O operations and lack of parallelization - Tests had poor reliability in CI/CD environments without external tools installed - Code duplication existed across multiple test files with no shared utilities ### This commit - **Fixes dependency failures**: Added graceful skipping of tests requiring LibreOffice, Python, or other external tools when they're not available - **Optimizes performance**: Implemented thread-safe file content caching with 1,229x performance improvement (8,107 ns/op → 6.593 ns/op) - **Enables parallel execution**: Added `c.Parallel()` to all test functions and subtests for concurrent execution - **Creates fast test suite**: Added `fast_test.go` with dependency-free tests that complete in ~0.35 seconds for CI/CD pipelines - **Adds performance benchmarks**: Created `benchmark_test.go` to measure and track optimization improvements - **Consolidates utilities**: Extracted shared helper functions into `test_utils.go` to eliminate code duplication - **Maintains backward compatibility**: Preserves all existing test functionality while adding graceful degradation - **Improves test organization**: Separates dependency-heavy tests from lightweight ones for better maintainability
pinglin
added a commit
that referenced
this pull request
Sep 19, 2025
…ffice dependency failures (#1110) Because - Unit tests were failing with LibreOffice exit status 77 errors when external dependencies were missing - Test execution was extremely slow due to repeated file I/O operations and lack of parallelization - Tests had poor reliability in CI/CD environments without external tools installed - Code duplication existed across multiple test files with no shared utilities ### This commit - **Fixes dependency failures**: Added graceful skipping of tests requiring LibreOffice, Python, or other external tools when they're not available - **Optimizes performance**: Implemented thread-safe file content caching with 1,229x performance improvement (8,107 ns/op → 6.593 ns/op) - **Enables parallel execution**: Added `c.Parallel()` to all test functions and subtests for concurrent execution - **Creates fast test suite**: Added `fast_test.go` with dependency-free tests that complete in ~0.35 seconds for CI/CD pipelines - **Adds performance benchmarks**: Created `benchmark_test.go` to measure and track optimization improvements - **Consolidates utilities**: Extracted shared helper functions into `test_utils.go` to eliminate code duplication - **Maintains backward compatibility**: Preserves all existing test functionality while adding graceful degradation - **Improves test organization**: Separates dependency-heavy tests from lightweight ones for better maintainability
pinglin
added a commit
that referenced
this pull request
Sep 19, 2025
…ffice dependency failures (#1110) Because - Unit tests were failing with LibreOffice exit status 77 errors when external dependencies were missing - Test execution was extremely slow due to repeated file I/O operations and lack of parallelization - Tests had poor reliability in CI/CD environments without external tools installed - Code duplication existed across multiple test files with no shared utilities ### This commit - **Fixes dependency failures**: Added graceful skipping of tests requiring LibreOffice, Python, or other external tools when they're not available - **Optimizes performance**: Implemented thread-safe file content caching with 1,229x performance improvement (8,107 ns/op → 6.593 ns/op) - **Enables parallel execution**: Added `c.Parallel()` to all test functions and subtests for concurrent execution - **Creates fast test suite**: Added `fast_test.go` with dependency-free tests that complete in ~0.35 seconds for CI/CD pipelines - **Adds performance benchmarks**: Created `benchmark_test.go` to measure and track optimization improvements - **Consolidates utilities**: Extracted shared helper functions into `test_utils.go` to eliminate code duplication - **Maintains backward compatibility**: Preserves all existing test functionality while adding graceful degradation - **Improves test organization**: Separates dependency-heavy tests from lightweight ones for better maintainability
pinglin
added a commit
that referenced
this pull request
Sep 19, 2025
…ffice dependency failures (#1110) Because - Unit tests were failing with LibreOffice exit status 77 errors when external dependencies were missing - Test execution was extremely slow due to repeated file I/O operations and lack of parallelization - Tests had poor reliability in CI/CD environments without external tools installed - Code duplication existed across multiple test files with no shared utilities ### This commit - **Fixes dependency failures**: Added graceful skipping of tests requiring LibreOffice, Python, or other external tools when they're not available - **Optimizes performance**: Implemented thread-safe file content caching with 1,229x performance improvement (8,107 ns/op → 6.593 ns/op) - **Enables parallel execution**: Added `c.Parallel()` to all test functions and subtests for concurrent execution - **Creates fast test suite**: Added `fast_test.go` with dependency-free tests that complete in ~0.35 seconds for CI/CD pipelines - **Adds performance benchmarks**: Created `benchmark_test.go` to measure and track optimization improvements - **Consolidates utilities**: Extracted shared helper functions into `test_utils.go` to eliminate code duplication - **Maintains backward compatibility**: Preserves all existing test functionality while adding graceful degradation - **Improves test organization**: Separates dependency-heavy tests from lightweight ones for better maintainability
jvallesm
added a commit
to instill-ai/instill-core
that referenced
this pull request
Sep 23, 2025
Because - The version of the pipeline-backend service is not updated in the instill-core repository. This commit - updates the `PIPELINE_BACKEND_VERSION` in the `.env` file to `1b4cd1f`. - updates the `pipelineBackend.image.tag` in the helm chart values.yaml file to `1b4cd1f`. ## Changes in pipeline-backend - fix(text): correct positions on duplicate markdown chunks (instill-ai/pipeline-backend#1120) - refactor(component,generic,http): replace env-based URL validation with constructor injection (instill-ai/pipeline-backend#1121) - fix(usage): add missing error filtering for users/admin (instill-ai/pipeline-backend#1119) - feat(component,ai,gemini): implement File API support for large files… (instill-ai/pipeline-backend#1118) - perf(data): optimize struct marshaling/unmarshaling with caching and … (instill-ai/pipeline-backend#1117) - feat(data): enhance unmarshaler with JSON string to struct conversion (instill-ai/pipeline-backend#1116) - feat(data): implement time types support with pattern validation (instill-ai/pipeline-backend#1115) - feat(component,ai,gemini): add multimedia support with unified format… (instill-ai/pipeline-backend#1114) - ci(workflows): adopt GitHub-hosted runner (instill-ai/pipeline-backend#1113) - perf(data): enhance comprehensive format coverage and optimize test performance (instill-ai/pipeline-backend#1112) - ci(workflows): adopt loarger runner for coverage test (instill-ai/pipeline-backend#1111) - perf(component,operator,document): optimize unit tests and fix LibreOffice dependency failures (instill-ai/pipeline-backend#1110) - perf(component,operator,video): optimize unit test performance by 59.7% (instill-ai/pipeline-backend#1109) - perf(component,operator,image): optimize unit tests for 98.5% faster … (instill-ai/pipeline-backend#1107) - ci(docker): optimize Dockerfiles with multi-stage builds for faster build times (instill-ai/pipeline-backend#1108) - perf(data): implement automatic field naming convention detection with LRU caching (instill-ai/pipeline-backend#1105) - feat(component,ai,gemini): enhance streaming to output all fields (instill-ai/pipeline-backend#1106) - fix(component,ai,gemini): correct text-based documents logic (instill-ai/pipeline-backend#1103) - test(component,generic,http): replace external httpbin.org dependency with local test server (instill-ai/pipeline-backend#1101) - ci(docker): add GitHub fallback for ffmpeg installation (instill-ai/pipeline-backend#1102) Co-authored-by: jvallesm <3977183+jvallesm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
c.Parallel()to all test functions and subtests for concurrent executionfast_test.gowith dependency-free tests that complete in ~0.35 seconds for CI/CD pipelinesbenchmark_test.goto measure and track optimization improvementstest_utils.goto eliminate code duplication