fix(usage): add missing error filtering for users/admin #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinglin
deleted the
pinglin/fix-usage-add-missing-error-filtering-for-users-admin
branch
This was referenced Sep 22, 2025
jvallesm
added a commit
to instill-ai/instill-core
that referenced
this pull request
Sep 24, 2025
Because - The version of the artifact-backend service is not updated in the instill-core repository. This commit - updates the `ARTIFACT_BACKEND_VERSION` in the `.env` file to `56f0368`. - updates the `artifactBackend.image.tag` in the helm chart values.yaml file to `56f0368`. ## Changes in artifact-backend - fix(reprocess): clean up data from previous file processing (instill-ai/artifact-backend#259) - fix(usage): add missing error filtering for users/admin (instill-ai/artifact-backend#257) Co-authored-by: jvallesm <3977183+jvallesm@users.noreply.github.com>
jvallesm
pushed a commit
that referenced
this pull request
Oct 7, 2025
🤖 I have created a release *beep* *boop* --- ## [0.33.0](v0.32.0...v0.33.0) (2025-09-30) ### Features * **chunking:** page by chunk when page delimiters are present ([#262](#262)) ([13b766e](13b766e)) * **conversion:** add char length to text files ([#261](#261)) ([c92684f](c92684f)) * **conversion:** extract pages in conversion step ([#260](#260)) ([925dd1c](925dd1c)) ### Bug Fixes * **reprocess:** clean up data from previous file processing ([#259](#259)) ([56f0368](56f0368)) * **usage:** add missing error filtering for users/admin ([#257](#257)) ([c42ac14](c42ac14)) ### Miscellaneous * **blob:** make file blob paths more descriptive ([#263](#263)) ([c23ad31](c23ad31)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Prepare 0.33.0 release by updating CHANGELOG and bumping manifest version. > > - **Release 0.33.0** > - Update `CHANGELOG.md` with: > - **Features**: chunking by page when delimiters exist; conversion adds char length to text files; extract pages during conversion. > - **Bug Fixes**: cleanup stale data on reprocess; add missing error filtering for users/admin. > - **Misc**: more descriptive file blob paths. > - Bump version in `release-please/manifest.json` from `0.32.0` to `0.33.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c4e8bbd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
TriggerSingleReportermethod was missing the same error filtering logic that exists inNewUsageandStartReportermethodsGetUserAdminfails with "users/admin" error, it should be treated as a debug message rather than an error since only Instill Core CE has the default "admin" userThis commit
TriggerSingleReporterthat already exists inNewUsageandStartReporter