Change samples source empty selector component in box creation #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
reviewed
Jan 19, 2023
Contributor
ysbaddaden
left a comment
ysbaddaden
left a comment
There was a problem hiding this comment.
Nice! I think we can improve the JS glue a bit :)
ysbaddaden
approved these changes
Jan 20, 2023
leandroradusky
deleted the
feature/1778-changes-sources-empties-selector-components
branch
leandroradusky
restored the
feature/1778-changes-sources-empties-selector-components
branch
leandroradusky
deleted the
feature/1778-changes-sources-empties-selector-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1778.
When the source of samples in box creation is changed, a warning message is shown:
To accomplish this, react selector components reset to empty state by clicking a hidden
<a>. It's the best way I found to apply changes within React components from plain javascript. Not sure it's the best way.The javascript is commented because it has some complexity (should I put it in a separate file? don't know if it's a rule to do it or not). At least, some jquery is gone :)