Add (Un)Blind Samples Button on Box Detail #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for Owners/Creators, if a box is transfered it will not show the button.
ysbaddaden
requested changes
Nov 20, 2022
Contributor
ysbaddaden
left a comment
ysbaddaden
left a comment
There was a problem hiding this comment.
Nice! Just a few readability enhancements, but most importantly the authorization to improve.
added 2 commits
November 25, 2022 11:04
- avoid adding .row-action-actions - use of transferred method - unblind checking permissions changed
Contributor
|
@omelao Can I bother you to add controller specs for the
Those specs are important to ensure that we don't inadvertently break the authorizations later! |
Contributor
Author
|
Yeah. Sure. |
Contributor
Author
|
@ysbaddaden done |
ysbaddaden
approved these changes
Dec 2, 2022
ysbaddaden
deleted the
1772-allow-to-edit-the-box-just-the-blind-check-box
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for Owners/Creators, if a box is transfered it will not show the button.