1598 show date last modified date in samples

[omelao]

I don't know if we need to consider some conflict between Modified From/To and Modified Dropdown filters. I don't think it would be a problem. So this is it.

[diegoliberman]

@omelao it could be useful to add a couple of screenshots in the PRs. Showing how it looked before the PR and how it will look after merging. This will help the reviewer and any watcher to (perhaps) spot issues in advance. We don't do this for all PRs, perhaps because we forget, or because we think it isn't necessary. :)

[omelao]

Before

After

[ysbaddaden]

Nice job! Just one big issue to fix; the rest is to improve things further.

That being said, I think we should have either a pair of from/to date selectors or a drodpown selector to select a range, but both is too much. What do you think @jkicillof and @diegoliberman?

[diegoliberman]

That being said, I think we should have either a pair of from/to date selectors or a drodpown selector to select a range, but both is too much. What do you think @jkicillof and @diegoliberman?

I agree. The From - To is the most flexible option, so I would keep that. Sorry for the confusion, the dropdown was an alternative in case it was much easier to do.

cc @omelao

[jkicillof]

Do we really need from/to? could a list of time spans be enough? something like last week, last month, last year. If we need and extra row to fit all the filters we could use something like this: collapsed, expanded and leave visible by default the most common ones. I don't know if this is already implemented somewhere.

[jkicillof]

A few style comments:

1. Combo text should be black
   
2. Placeholder text should be grey like the label
   

[diegoliberman]

Do we really need from/to? could a list of time spans be enough? something like last week, last month, last year.

I prefer to be more flexible right now, and allow the user to select whatever range they need.

[omelao]

Do we really need from/to? could a list of time spans be enough? something like last week, last month, last year.

I prefer to be more flexible right now, and allow the user to select whatever range they need.

Yes, I think it's better too. Should I remove the Dropdown?

[diegoliberman]

@omelao you can move ahead with deleting the dropdown. Let us know if you need anything. Thanks!

[omelao]

Yes I removed, I will just see if I can change the placeholder of a input date field.

[ysbaddaden]

I just left a few comments.

[omelao]

@straight-shoota @ysbaddaden what do you think about this comment?

/*
This is kind of a exception solution. Because input date's behavior are different.
Consider this points:

• input date's placeholders doesn't work
• even if at some point in the future it works, date format's depends of the browser and OS
• CSS selectors like :empty, :valid, [value=''], :placeholder-shown doesn't work
• Google Chrome has specific selector to coloring the content of this kind of fields, but other browser doesn't

Finally you can test if something changes on the future on this fiddle:
https://jsfiddle.net/omelao/hsk8vyax/15/
*/

Maybe I could put all of this on the fiddle, and just link the fiddle on the comment.