Add SamplesReports permissions to predefined roles

[leandroradusky]

Context: for the new entity SamplesReports permissions are not set for existing users.

Solution: do the same that was done in #1687 for the Box entity.

[ysbaddaden]

@sardar-usman I'll do the QA for this one (it's manually running a migration task on the server).

[ysbaddaden]

@sardar-usman I ran the command on staging, and the "samples report" policies were added to the default institution & site roles (admin & reader).

I verified and the policies were correctly added to my institutions. You might want to have a look also.

[diegoliberman]

I updated statuses in Commit (Dev done, Review done) and set the pending to zero instead of 1h. cc @ysbaddaden

[ysbaddaden]

@sardar-usman I can't find any issue in the automated task.

The permissions added are identical to the default permissions when we create an institution (the roles must have the exact same name as the default ones, otherwise they are special roles, and we don't add the permission). In this case:

• it adds the institution:createSamplesReport permission to "Institution Admin" roles;
• it adds the samplesReport:* permission to "Institution Admin" roles (can do anything);
• it adds the samplesReport:read permission to "Institution Reader" roles (can only read).

Site roles don't have any permission over samples report by default, they must be added manually.

[diegoliberman]

@ysbaddaden I'm not getting permission to create Samples Report in Staging. Institution UCSD Demo. User dliberman+ucsd+demo@manas.com.ar.

[ysbaddaden]

Would it be possible that the policy isn't computed for owners?

[ysbaddaden]

Urgh. We ADDED a resource and thus ADDED new policies so we MUST run a rake task to recompute the policies 🤦

This is all documented in the wiki:
https://github.com/instedd/cdx/wiki/Granting-proper-access-after-creating-a-new-entity:-Policies---Permissions---Roles

[ysbaddaden]

So, during the next release, we must run these tasks:

$ bin/rails policy:add_samples_report_permissions
$ bin/rails policy:calculate_computed

[ysbaddaden]

@diegoliberman @sardar-usman the samples report permissions have now have been recomputed for existing users, not only added to the default roles!

[diegoliberman]

Thanks @ysbaddaden !

PS: I think this rake command troubled us about 4 times already :P