Skip to content

add a modified version of the fibonacci layouts #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add a modified version of the fibonacci layouts #59

wants to merge 4 commits into from

Conversation

bob8677
Copy link
Contributor

@bob8677 bob8677 commented Dec 10, 2020

The change I made were:

  1. making the layout affected by nmaster
  2. make proper splitting of old numbers
  3. allowing windows to expand into extra area from windows with a fixed aspect ration.
    Should be tested further
    20201209225251
    20201209225255

@con-f-use con-f-use requested a review from paperbenni December 10, 2020 14:51
@con-f-use con-f-use added the enhancement New feature or request label Dec 10, 2020
@con-f-use
Copy link
Member

Which image shows what?

@bob8677
Copy link
Contributor Author

bob8677 commented Dec 10, 2020 •
edited
Loading

Sorry, I should have been more clear. Those images were showing how the windows expand into the area that a window may have left behind if it has a locked aspect ratio. Here are some more images for clarity.
This is what happens with the original unmodified layout
20201210090606
This is the dwindle layout in this pr with 3 windows in the master
20201210091026
Same thing but with the spiral layout
20201210091148

@con-f-use
Copy link
Member

Okay, now you just have to test the living s**t out of it 😁

@bob8677
init fibonacci layouts
2c499e8 
add fibonacci layouts to layouts.h

add fibonacci layouts to instantwmctrl.sh

add fibonacci layouts to config.def.h

fix spacing in instantwmctrl

add comments to layouts.c
@bob8677 bob8677 force-pushed the master branch 2 times, most recently from 1197e6c to 2c499e8 Compare December 10, 2020 22:30
@bob8677 bob8677 marked this pull request as ready for review December 11, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paperbenni paperbenni Awaiting requested review from paperbenni

Assignees

@paperbenni paperbenni

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bob8677 @con-f-use @paperbenni