Skip to content

Fix: Adapt to instana spec on HTTP span processing #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 17, 2024
Merged

Fix: Adapt to instana spec on HTTP span processing #653

merged 9 commits into from
Oct 17, 2024

Conversation

@GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Oct 17, 2024

  • fixes integration tests

@GSVarsha
fix(tracestate, traceparent): with_suppression_and_w3c
4fa6d04 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix: Test Case 28 of integration tests
bd71443 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix: server timing, x-instana-t
e7d7a1c 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix span context entries
a22747c 
- SpanContext uses a Tuple hence cannot be modified after creation

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix: handle Instana headers with 128 bit trace ID
559f47e 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix: format span.lt before sending to agent
022c859 
- `span_context.traceid` logic try
- fix: receive `span.crid` and `span.crtp` on non-recording spans as well

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix: synthetic
7e7a85d 
- set `span.sy` only for entry spans when `synthetic=True`

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
fix: aws/01_lambda failures
0ee2906 
- fix: handle `str` internal ids with all digit chars
- rename the methods to handle internal ids

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Oct 17, 2024
@GSVarsha GSVarsha added bug Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Oct 17, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Oct 17, 2024
@GSVarsha GSVarsha requested review from CagriYonca and pvital October 17, 2024 05:21
@GSVarsha GSVarsha force-pushed the fix_adapt_instana_spec branch from 28bc95f to 29a7aae Compare October 17, 2024 10:32
@GSVarsha
fix(tests): failing tests after changes
6338ef6 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the fix_adapt_instana_spec branch from 29a7aae to 6338ef6 Compare October 17, 2024 11:36
pvital
pvital approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital merged commit 9e0300a into master Oct 17, 2024
2 checks passed
@pvital pvital deleted the fix_adapt_instana_spec branch October 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@GSVarsha GSVarsha

Labels

bug OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge

Projects

None yet

Milestone

H2-2024

Development

Successfully merging this pull request may close these issues.

3 participants

@GSVarsha @pvital