Skip to content

Conversation

@GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Oct 4, 2024

Fix flaky tests

  • Always return True for HostAgent.is_agent_listening()
  • Register pytest marker: pytest.mark.original
  • Fix warnings

Results

CircleCI

Screenshot 2024-10-04 at 3 19 18 PM

Tekton CI

Screenshot 2024-10-04 at 3 34 26 PM

- Always return `True` for `HostAgent.is_agent_listening()`

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha added this to the H2-2024 milestone Oct 4, 2024
@GSVarsha GSVarsha self-assigned this Oct 4, 2024
@GSVarsha GSVarsha added the WIP work in progress label Oct 4, 2024
- ```
/workspace/python-sensor/tests/agent/test_host.py:125: PytestUnknownMarkWarning: Unknown pytest.mark.original - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.original
```

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha removed the WIP work in progress label Oct 4, 2024
@GSVarsha GSVarsha marked this pull request as ready for review October 4, 2024 09:44
@GSVarsha GSVarsha requested review from CagriYonca and pvital October 4, 2024 09:44
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital merged commit 5f3464f into master Oct 4, 2024
@pvital pvital deleted the fix-flaky-tests branch October 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants