fix: Ensure trace level from current context is considered #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferenc-
force-pushed
the
fix-tracing-level
branch
2 times, most recently
from
a2d18bc to
7c54ae0
Compare
Ferenc-
force-pushed
the
fix-tracing-level
branch
from
7c54ae0 to
dde4f13
Compare
Ferenc-
changed the title
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
GSVarsha
reviewed
Aug 7, 2024
| span_id = span_context.span_id | ||
| # Suppression `level` made in the child context or in the parent context | ||
| # has priority over any non-suppressed `level` setting | ||
| child_level = int(self.extract_instana_headers(carrier)[2] or "1") |
Contributor
There was a problem hiding this comment.
Hi @Ferenc- , according to PEP 333, response_headers are a list of tuples. I tested with wsgi frameworks bottle and cherrypy and both of them produce errors with our existing code on the master branch.
2024-08-07 18:38:40,399: 43705 DEBUG instana: extract error:
Traceback (most recent call last):
File "/Users/varsha/Documents/GitHub/instana-repos/tracer-repos/python-sensor/src/instana/propagators/base_propagator.py", line 221, in extract_instana_headers
trace_id = dc.get(self.LC_HEADER_KEY_T) or dc.get(self.ALT_LC_HEADER_KEY_T) or dc.get(
AttributeError: 'list' object has no attribute 'get'
# bottle
<class 'list'> [('Content-Length', '12'), ('Content-Type', 'text/html; charset=UTF-8')]
# cherrypy
<class 'list'> [('Content-Type', 'text/html;charset=utf-8'), ('Server', 'CherryPy/18.10.0'), ('Date', 'Wed, 07 Aug 2024 13:08:40 GMT'), ('Content-Length', '11')]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.